Skip to content

Move ASan CI job to reusable-san.yml - #159367

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:refactor-asan
Oct 17, 2026
Merged

Move ASan CI job to reusable-san.yml#159367
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:refactor-asan

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Oct 13, 2026

Copy link
Copy Markdown
Member

This refactors the CI configuration for ASan to deduplicate some logic, and bring it together with the other sanitzers.

As a sideeffect, it will also run --with-pydebug and build with the Clang compiler.

@StanFromIreland
Move ASan CI job to reusable-san.yml
f568688 
This refactors the CI configuration for ASan to deduplicate some logic,
and bring it together with the other sanitzers.

As a sideeffect, it will also run `--with-pydebug` and build with the
Clang compiler.
@StanFromIreland StanFromIreland added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Oct 13, 2026
@StanFromIreland

StanFromIreland commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

If there are no objections, I'll merge this in a few days.

@StanFromIreland StanFromIreland added the type-refactor Code refactoring (with no changes in behavior) label Oct 17, 2026
@hugovk

hugovk commented Oct 17, 2026

Copy link
Copy Markdown
Member

This switches from xvfb-run make ci, which passes --fast-ci, to ./python -m test -j4 -W --timeout=900 --slowest, so resource-enabled and Tk GUI tests no longer run.

Is this intentional or okay to skip under ASan?

@StanFromIreland

StanFromIreland commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Tk GUI tests no longer run.

They are skipped anyway (tests involving libX11 can segfault on ASan builds), see this run for example.

As for the other resources, most of them are network related (since we exclude cpu), I'm not sure they add that much C coverage here. I could add them back if that's preferred?

JacobCoffee
JacobCoffee approved these changes Oct 17, 2026
View reviewed changes

@JacobCoffee JacobCoffee left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an aside, i wonder if itd be better to use a team in codeowners so that this...

Image

isnt a thing (the multi user ref lines for all the individual codeowners)

@StanFromIreland

StanFromIreland commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

To be honest, I feel like it's not worth the additional complexity. Currently, people can easily add or remove themselves, and they also have the option to be as specific as they'd like. LLVM does this to an extent, and it's a bit of pain to wait for an administrator to add or remove you from a team (and, you also have less control over what you're subscribing to).

@JacobCoffee Linear Code

JacobCoffee commented Oct 17, 2026

Copy link
Copy Markdown
Member

true! im not fussed about it either way :D

hugovk
hugovk approved these changes Oct 17, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 17, 2026
@StanFromIreland

StanFromIreland commented Oct 17, 2026

Copy link
Copy Markdown
Member Author

Considering we now have Dependabot configured to create PRs against each branch individually, do we need to bother backporting all the way?

@StanFromIreland
StanFromIreland merged commit 18f3a71 into python:main Oct 17, 2026
106 of 108 checks passed
@StanFromIreland
StanFromIreland deleted the refactor-asan branch October 17, 2026 19:17
@miss-islington-app

miss-islington-app Bot commented Oct 17, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 17, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 18f3a718e1f884cde4a07392403af79147158425 3.15

@miss-islington-app

miss-islington-app Bot commented Oct 17, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 18f3a718e1f884cde4a07392403af79147158425 3.14

@StanFromIreland StanFromIreland removed needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@JacobCoffee JacobCoffee JacobCoffee approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip issue skip news type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @hugovk @JacobCoffee